Skip to content

[DeadCode] Clean up unnecessary reindex use on RemoveUnusedClosureVariableUseRector#7433

Merged
samsonasik merged 1 commit intomainfrom
clean-up-unne-reindex
Oct 5, 2025
Merged

[DeadCode] Clean up unnecessary reindex use on RemoveUnusedClosureVariableUseRector#7433
samsonasik merged 1 commit intomainfrom
clean-up-unne-reindex

Conversation

@samsonasik
Copy link
Member

this is not needed, already covered at NodeAttributeReIndexer, see

if ($node instanceof Closure) {
$node->uses = array_values($node->uses);
}

Ref #7430 (review)

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik enabled auto-merge (squash) October 5, 2025 14:38
@samsonasik samsonasik merged commit fe7432b into main Oct 5, 2025
50 checks passed
@samsonasik samsonasik deleted the clean-up-unne-reindex branch October 5, 2025 14:39
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant